Skip to content

URGENT: patch out RawDir for the next release too #472

Closed
@SUPERCILEX

Description

@SUPERCILEX

@sunfishcode pretty sure I done goofed again. Was listening to the ghost cell podcast and Ralf talked about how you can access all of the elements of the Iterator at the same time thanks to the non-aliasing references. Anyway, I was like, "doesn't raw dir work that way since the lifetime is bound to the buffer?" And then: "Oh shit, we reuse that buffer."

TL;DR: pretty sure people can accumulate entry references into some other structure, but they'll be garbage once the buffer restarts. Need to double check tomorrow. Somehow need lifetime that is bound to the buffer so it can't be dropped but also blocks aliasing so every call to next requires dropping the previous entry.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions