Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function name #7

Open
topepo opened this issue Mar 27, 2021 · 4 comments
Open

function name #7

topepo opened this issue Mar 27, 2021 · 4 comments

Comments

@topepo
Copy link

topepo commented Mar 27, 2021

gam_mod() is a little short (and redundant). Maybe generalized_additive_mod() or general_additive_mod()?

@mdancho84
Copy link
Contributor

We can do it. Let me think about which one to go with, but yes I agree that the name should be much more descriptive.

@mdancho84
Copy link
Contributor

What about additive_model() as the general specification and then gam as the engine?

@mdancho84
Copy link
Contributor

mdancho84 commented Mar 28, 2021

I'm testing a few out. What about gen_additive_mod()? Still keeps things concise without being redundant.

@mdancho84
Copy link
Contributor

Hey, I refactored to gen_additive_mod(). Give it a look over and see if you like it.

If not, my next pick would be general_additive_mod() since it's only slightly longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants