Add rename_identical_headers option to get_all_records - #1602
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1436.
get_all_records()raises when the header row has duplicate or blank entries, since they can't all be dictionary keys. This adds an opt-inrename_identical_headersflag so those headers are made unique instead, similar to how pandas reads a sheet like that:The renaming itself lives in a new
utils.make_headers_unique()helper (as suggested in the issue), so it's also usable on its own alongsideto_records(). Blank headers get named after their column position, duplicates get a numbered suffix, and both patterns are overridable via astr.formattemplate.Default is
False, so existing behavior is unchanged. Added unit tests for the helper and an integration test for the new flag, plus a note in the user guide.