Fix coverage (#86)

Author: 0aix

src/test/java/com/yahoo/bullet/querying/ProjectionTest.java

@@ -9,6 +9,7 @@
 import com.yahoo.bullet.query.expressions.BinaryExpression;
 import com.yahoo.bullet.query.expressions.FieldExpression;
 import com.yahoo.bullet.query.expressions.Operation;
+import com.yahoo.bullet.query.expressions.UnaryExpression;
 import com.yahoo.bullet.record.BulletRecord;
 import com.yahoo.bullet.record.avro.TypedAvroBulletRecordProvider;
 import com.yahoo.bullet.result.RecordBox;
@@ -34,7 +35,8 @@ public void testProjectNewRecord() {
                                            new Field("f", new BinaryExpression(new FieldExpression("d"),
                                                                                new FieldExpression("e"),
                                                                                Operation.ADD)),
-                                           new Field("g", new FieldExpression("g")));
+                                           new Field("g", new FieldExpression("g")),
+                                           new Field("h", new UnaryExpression(new FieldExpression("a"), Operation.SIZE_OF)));
 
         Projection projection = new Projection(fields);
         BulletRecord newRecord = projection.project(record, new TypedAvroBulletRecordProvider());
@@ -62,7 +64,8 @@ public void testProjectOldRecord() {
                                            new Field("e", new BinaryExpression(new FieldExpression("e"),
                                                                                new FieldExpression("f"),
                                                                                Operation.SUB)),
-                                           new Field("f", new FieldExpression("f")));
+                                           new Field("f", new FieldExpression("f")),
+                                           new Field("h", new UnaryExpression(new FieldExpression("a"), Operation.SIZE_OF)));
 
         Projection projection = new Projection(fields);
         BulletRecord oldRecord = projection.project(record);

src/test/java/com/yahoo/bullet/querying/postaggregations/OrderByStrategyTest.java

@@ -206,4 +206,21 @@ public void testOrderByComputationWithMissingField() {
         Assert.assertEquals(result.getRecords().get(3).typedGet("a").getValue(), "world");
         Assert.assertEquals(result.getRecords().get(4).typedGet("a").getValue(), "foobar");
     }
+
+    @Test
+    public void testOrderByComputationWithBadComputation() {
+        OrderByStrategy orderByStrategy = makeOrderBy(Collections.singletonList(new OrderBy.SortItem(new UnaryExpression(new FieldExpression("a"), Operation.SIZE_OF), OrderBy.Direction.ASC)));
+        List<BulletRecord> records = new ArrayList<>();
+        records.add(RecordBox.get().add("a", 1).getRecord());
+        records.add(RecordBox.get().add("a", 3).getRecord());
+        records.add(RecordBox.get().add("a", 2).getRecord());
+        Clip clip = new Clip();
+        clip.add(records);
+        Clip result = orderByStrategy.execute(clip);
+
+        // Order should not change
+        Assert.assertEquals(result.getRecords().get(0).typedGet("a").getValue(), 1);
+        Assert.assertEquals(result.getRecords().get(1).typedGet("a").getValue(), 3);
+        Assert.assertEquals(result.getRecords().get(2).typedGet("a").getValue(), 2);
+    }
 }