-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better Windows CNB contribution workflow documentation #826
Comments
@micahyoung do we have an owner for this issue predetermined? |
I'm happy to take a first pass. I'll at least come up with something other folks can try out and refine or help us make another attempt. Sound ok? |
Here's a minimal WIP approach so far. https://github.com/buildpacks/pack/wiki/Windows-WCOW-Docker-Daemon-on-Cloud-VM |
Thoughts:
Exposing the docker daemon on tcp feels like a dip in security to me. Especially if the user is only expected to work via an ssh session.
While I'm not uneasy about this from a security standpoint, locking down the IP range bodes better with the principle of least privilege.
We would want to make sure that the private IP is what is making it into the host file. The last time I tried a public IP, the acceptance tests were routinely failing due a timeout. Mileage may vary with the IAAS though.
I think we should be setting up |
Good call. One alternative I've been considering is making a container image with a small binary that proxies TCP traffic to the socket, instead of the daemon opening the port itself. Then, it's only active when the containers is explicitly started (from RDP or whatever), and we could potentially add better security mechanisms (like TLS, IP whitelisting, auto shutoff or something). But that might not be needed, if we chose to not support
Yeah, I think we'll have to use the IP Supporting
👍 |
Description
Contributing Windows features, or debugging unintentional Windows CI failures, is complex and has a steeper learning curve that other OSes, especially for Windows containers.
Proposed solution
Document the process of Windows development and debugging by setting up a minimal Windows dev environment. This should assume the following:
make
with packDescribe alternatives you've considered
Additional context
Notes
[1] 1809 will be the most common OS version for k8s and corporate customers
[2] Microsoft implies this can only be done by the Windows store but it's much easier using Ubuntu's appx
The text was updated successfully, but these errors were encountered: