Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image pack:base does not include shell #2111

Closed
kaiomatico opened this issue Mar 28, 2024 · 7 comments · Fixed by #2240
Closed

Docker Image pack:base does not include shell #2111

kaiomatico opened this issue Mar 28, 2024 · 7 comments · Fixed by #2240
Assignees
Labels
status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.

Comments

@kaiomatico
Copy link

Summary

Running the command docker run --rm --it --entrypoint sh buildpacksio/pack:0.33.2-base works fine, but docker run --rm --it --entrypoint sh buildpacksio/pack:base results in the error that sh could not be found in $PATH


Reproduction

Steps

See above

Current behavior

sh could not be found in $PATH on the base image without version tag

Expected behavior

sh should be included in the base image tag just like it is on the 0.33.2-base image tag


Environment

pack info
docker info

Docker 24.0.5 on Linux

@kaiomatico kaiomatico added status/triage Issue or PR that requires contributor attention. type/bug Issue that reports an unexpected behaviour. labels Mar 28, 2024
@jjbustamante jjbustamante added type/chore Issue that requests non-user facing changes. status/ready Issue ready to be worked on. and removed type/bug Issue that reports an unexpected behaviour. status/triage Issue or PR that requires contributor attention. labels Apr 1, 2024
@jjbustamante
Copy link
Member

I think the problem is in this line

We expect to retag the base, jammy image to :base but we are using an image reference without the ${{ matrix.suffix }} and we ended up copying the tiny image (based on distroless)

@hhiroshell
Copy link
Contributor

I am relatively new to this repository, and although this issue does not have a 'good first issue' label, may I still try to tackle it?

I understand that testing a fix for this issue, especially within a GitHub Action job, is not a simple task. For now, I'm thinking of creating a repository with the necessary files to reproduce it and checking the changes to eliminate the problem in the repo.

Is there any recommendation for the testing procedure?

@natalieparellano
Copy link
Member

@hhiroshell we would love to have your help with this!

For testing stuff out with GitHub Actions (especially jobs that only run after a release) sometimes building out a fork is the only way to do it. But, you might remove the jobs that are irrelevant to what you are testing or require cumbersome setup (see here what we do for the lifecycle including stripping out all tests). Let us know if you run into any issues with it, so that we can unblock you if we can.

@hhiroshell
Copy link
Contributor

@natalieparellano Thank you so much for such helpful information. I'll give it a try to do the same!

@hhiroshell
Copy link
Contributor

@natalieparellano
I encountered some issues with the tools/test-fork.sh script in the lifecycle repository when I tried to run it, so I created a PR to fix them. Could you please review it?

@hhiroshell
Copy link
Contributor

@natalieparellano
I created a PR adding a script for the same purpose as the tools/test-fork.sh in the lifecycle repository.

I apologize for the repeated requests, but could you please review it?

@hhiroshell
Copy link
Contributor

@natalieparellano
Thank you for reviewing the series of PRs.

It was also beneficial to study the release process for my understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants