Only set git-mirrors-path when EnableAgentGitMirrorsExperiment #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If/when buildkite-agent promotes git-mirrors from experimental, the presence of git-mirrors-path will enable the feature. We currently set git-mirrors-path even when EnableAgentGitMirrorsExperiment is false, which would lead to unexpected activation of the feature.
pda
commented
Aug 19, 2020
| @@ -86,7 +87,7 @@ timestamp-lines=${Env:BUILDKITE_AGENT_TIMESTAMP_LINES} | |||
| hooks-path="C:\buildkite-agent\hooks" | |||
| build-path="C:\buildkite-agent\builds" | |||
| plugins-path="C:\buildkite-agent\plugins" | |||
| git-mirrors-path="C:\buildkite-agent\git-mirrors" | |||
| git-mirrors-path="${Env:BUILDKITE_AGENT_GIT_MIRRORS_PATH}" | |||
There was a problem hiding this comment.
I don't know much Windows / PowerShell and was worried this might fail if the env wasn't set at all, which is the case when BUILDKITE_AGENT_ENABLE_GIT_MIRRORS_EXPERIMENT is false.
I've confirmed¹ that it results in git-mirrors-path="" in the Windows buildkite-agent.cfg file when that env var isn't present 👌🏼
¹ a decade of using AWS/EC2, and this is the first time I've ever connected to a windows instance 😬
|
I've also cherry-picked this onto the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently set
git-mirrors-patheven whenEnableAgentGitMirrorsExperimentisfalse. That would lead to unexpected activation of the feature if a newer version of https://github.com/buildkite/agent promotesgit-mirrorsfrom experiment status.This patch configures
git-mirrors-pathas an empty string unlessEnableAgentGitMirrorsExperimentistrue.