Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username from environment variable #78

Open
PriyaSudip opened this issue Aug 22, 2024 · 3 comments
Open

Username from environment variable #78

PriyaSudip opened this issue Aug 22, 2024 · 3 comments

Comments

@PriyaSudip
Copy link

PriyaSudip commented Aug 22, 2024

Currently username is passed through pipeline.yml as plugin input or read from agent hook if env for username set as "BUILDKITE_PLUGIN_DOCKER_LOGIN_USERNAME". It is not interpolated if it is set as an env via pipeline or post-checkout hook etc.

Since we are already passing the username in the pipeline.yml can we consider reading it from pipeline env or repo hook etc?

@toote
Copy link
Contributor

toote commented Aug 22, 2024

Instead of using the username plugin option, couldn't the pipeline or hook set the variable BUILDKITE_PLUGIN_DOCKER_LOGIN_USERNAME directly? I don't see why that wouldn't work

@PriyaSudip
Copy link
Author

@toote just removing username from plugin option works if we pass the env BUILDKITE_PLUGIN_DOCKER_LOGIN_USERNAME from pipeline directly or set via post-checkout.

Thanks!

@PriyaSudip
Copy link
Author

It seems the other usecase is to pass org specific env var to username in the plugin, this would need plugin username to accept env variable which could be anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants