Fix broken roundtrip by allowing guid's in create requests #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlainBolduc
reviewed
Feb 12, 2020
| |bim_snippet.reference|string|Reference of a BIM-Snippet of a topic|false| | ||
| |bim_snippet.reference_schema|string|Schema of a BIM-Snippet of a topic|false| | ||
| |due_date|string|Until when the topics issue needs to be resolved|false| | ||
| |guid|string|GUID of the topic. The server may ignore this and instead generate it's own guid|false| |
There was a problem hiding this comment.
This is a duplicate of line 753. This should have been put on line 753 instead.
AlainBolduc
reviewed
Feb 12, 2020
| "title": "document_reference_POST", | ||
| "type": "object", | ||
| "properties": { | ||
| "guid": { |
There was a problem hiding this comment.
Unless I don't understand the purpose of document reference, this makes no sense to include the "guid" here. Document reference should refer to an existing document in the project.
Contributor
Author
There was a problem hiding this comment.
A document reference could be either a link to an existing document or to an external url. For external URL's I think it makes sence to include the guid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken roundtrip by allowing guid's in create requests