Fixed the logic of discarding session #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YYChen01988
force-pushed
the
PLAT-12186/sessionTracker-discard-manual-sessions
branch
from
2ef477e to
50bb08a
Compare
Android notifier sizes
Generated by 🚫 Danger |
YYChen01988
force-pushed
the
PLAT-12186/sessionTracker-discard-manual-sessions
branch
from
50bb08a to
c11c811
Compare
lemnik
reviewed
May 23, 2024
YYChen01988
force-pushed
the
PLAT-12186/sessionTracker-discard-manual-sessions
branch
from
c11c811 to
4e298d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Discard the first automatic session when sessions are mixed with manual session
Changeset
Changing the logic for discarding session method
Testing
unit tests