Skip to content

improve Set performance as #issue107 descripes #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2020
Merged

improve Set performance as #issue107 descripes #196

merged 1 commit into from
Dec 24, 2020

Conversation

AllenX2018
Copy link
Collaborator

Description:
This pr improve the Set performance as #107 mentions.With large key path and set value, it brings an about 20% improvement.

Before:

goos: linux
goarch: amd64
pkg: github.com/buger/jsonparser
BenchmarkSetLarge-4   	    1000	   1002014 ns/op	 1611185 B/op	      15 allocs/op

After:

goos: linux
goarch: amd64
pkg: github.com/buger/jsonparser
BenchmarkSetLarge-4   	    1278	    791653 ns/op	 1232897 B/op	       4 allocs/op

@buger buger merged commit e015c37 into buger:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AllenX2018 @buger