Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] priv error #145

Closed
vet1ments opened this issue Sep 22, 2024 · 3 comments · Fixed by #144
Closed

[BUG] priv error #145

vet1ments opened this issue Sep 22, 2024 · 3 comments · Fixed by #144
Labels
Bug Something isn't working

Comments

@vet1ments
Copy link

vet1ments commented Sep 22, 2024

buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.34.2-20240717164558-a6c49f84cc0f.2 is ok
but
buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.34.2-20240920164238-5a7b106cbb87.2
in this version raise not found "priv.." (i dont know the detail) error

buf.yaml

version: v2
modules:
  - path: proto
lint:
  use:
    - STANDARD
breaking:
  use:
    - FILE
deps:
  - buf.build/bufbuild/protovalidate

buf,gen.yaml

version: v2
managed:
  enabled: true
  override:
    - file_option: go_package_prefix
      value: github.com/vet1ments/grpcoauth/go
  disable:
    - file_option: go_package_prefix
      module: buf.build/bufbuild/protovalidate
plugins:
  - local: protoc-gen-grpclib_python # async stub
    out: python
  - remote: buf.build/protocolbuffers/python:v28.2
    out: python
  - remote: buf.build/protocolbuffers/pyi:v28.2
    out: python
  - remote: buf.build/grpc/python
    out: python
  - remote: buf.build/protocolbuffers/go:v1.34.2
    out: go
    opt: paths=source_relative
  - remote: buf.build/connectrpc/go:latest
    out: go
    opt: paths=source_relative
  - remote: buf.build/grpc/go
    out: go
    opt: paths=source_relative
inputs:
  - directory: proto
@vet1ments vet1ments added the Bug Something isn't working label Sep 22, 2024
@jchadwick-buf jchadwick-buf transferred this issue from bufbuild/protovalidate Sep 23, 2024
@jchadwick-buf
Copy link
Member

Sorry about this: it is an unintended consequence of a breaking change that occurred in protovalidate. It's my own oversight, I didn't realize Go would start pulling the latest protovalidate changes before we updated the module in protovalidate-go.

Please stick to using version v1.34.2-20240717164558-a6c49f84cc0f.2 of the gencode for now. We will work on shipping the changes that fix this in #144 ASAP.

@jchadwick-buf jchadwick-buf pinned this issue Sep 23, 2024
@jchadwick-buf
Copy link
Member

We have released protovalidate-go v0.7.0 which will fix this issue. You can update to it using a command similar to go get -u github.com/bufbuild/protovalidate-go. Please note that v0.7.0 contains some breaking changes as well, which may require some code to be updated, though I believe for most users the impact will be fairly minimal.

Please let us know if you have any more issues. I apologize for the unexpected inconsistent state of the modules and will try to coordinate changes better in the future to hopefully prevent this confusing situation.

@vet1ments
Copy link
Author

vet1ments commented Sep 24, 2024

thank you so much for comfirming, All problems are solved

@rodaine rodaine linked a pull request Sep 24, 2024 that will close this issue
@jchadwick-buf jchadwick-buf unpinned this issue Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants