go.mod: bump protoc-gen-star to v0.5.3 #432
Merged
+3
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glerchundi
force-pushed
the
optional-support
branch
from
420fdbb to
09beccf
Compare
Contributor
Author
|
xref. |
Contributor
|
Hey @glerchundi. Let me see if I can approve your PGS PR. @rodaine has moved on from Lyft, and that repo has been in a bit of limbo, but I think I can help. Let me look into it before you try to merge this. |
Contributor
Author
|
Thanks @dkunitsk!! |
|
Is there any update on this? |
Contributor
Author
|
As far as I know nothing has changed since I opened the issues |
glerchundi
force-pushed
the
optional-support
branch
from
09beccf to
e9b67d1
Compare
glerchundi
changed the title
Contributor
Author
|
Scope of the PR changed as the changes in |
2 tasks
By bumping the version we gain the ability to add the supported features to the code generation response which helps by not erroring out when it gets called with the newly released protobuf 3.15. As the experimental flag for optionals was made mandatory if an `optional` clause exist in the source proto files. Signed-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
glerchundi
force-pushed
the
optional-support
branch
from
e9b67d1 to
7dc1593
Compare
akonradi
approved these changes
May 4, 2021
Contributor
Author
|
TFYR @akonradi!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By bumping the version we gain the ability to add the supported features
to the code generation response which helps by not erroring out when it
gets called with the newly released protobuf 3.15. As the experimental
flag for optionals was made mandatory if an
optionalclause exist inthe source proto files.
Signed-off-by: Gorka Lerchundi Osa glertxundi@gmail.com