Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kraken.exceptions.exceptions.KrakenExceptions to kraken.exceptions.KrakenException #66

Closed
btschwertfeger opened this issue Apr 7, 2023 · 0 comments · Fixed by #61
Closed

Move kraken.exceptions.exceptions.KrakenExceptions to kraken.exceptions.KrakenException #66

btschwertfeger opened this issue Apr 7, 2023 · 0 comments · Fixed by #61
Assignees
@btschwertfeger
Labels
Breaking Breaking changes Could Something that could be cool bit is not really important enhancement New feature or request
Milestone
v1.1.0

Comments

@btschwertfeger
Copy link
Owner

btschwertfeger commented Apr 7, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
As it has been before with the clients, the class KrakenExceptions can be moved into a __init__.py, which makes it easier to import.

Before (bad):

from kraken.exceptions.exceptions import KrakenExceptions

After (good):

from kraken.exceptions import KrakenException

Additional context
Even though the KrakenExceptions class are a collection of Kraken-specific errors, it would be good to stick to the singular standard.
@btschwertfeger btschwertfeger added enhancement New feature or request Could Something that could be cool bit is not really important labels Apr 7, 2023
@btschwertfeger btschwertfeger added this to the v1.1.0 milestone Apr 7, 2023
@btschwertfeger btschwertfeger self-assigned this Apr 7, 2023
@btschwertfeger btschwertfeger mentioned this issue Apr 7, 2023
Merged
@btschwertfeger btschwertfeger added the Breaking Breaking changes label Apr 14, 2023
@btschwertfeger btschwertfeger changed the title Move kraken.exceptions.exceptions.KrakenExceptions to `kraken.exceptions.KrakenException Move kraken.exceptions.exceptions.KrakenExceptions to kraken.exceptions.KrakenException Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btschwertfeger btschwertfeger

Labels
Breaking Breaking changes Could Something that could be cool bit is not really important enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Prepare Release v1.1.0 btschwertfeger/python-kraken-sdk
1 participant
@btschwertfeger