-
Notifications
You must be signed in to change notification settings - Fork 819
Open
Description
I think there is a bug with the pathfinding solution where it doesn't get neighbors correctly when the grid isn't square.
| const getNeighbors = (visited, x, y) => { |
if (y - 1 >= 0 && !visited[y - 1][x].closed) { is up
and ln 85 if (y + 1 < visited[0].length && !visited[y + 1][x].closed) { is down. Since we move up and down ln 85 should check visited.length not visited[0].length else it can run out of bounds with non square (rectangular) grids. Conversely ln 95 should be flipped to check visited[0].length since that is left and right and the nested arrays represent Xs max size.
I'm enjoying the course. Thanks!
Metadata
Metadata
Assignees
Labels
No labels