fix checks on mbr

ksshannon · ksshannon · commit 764515d035c4 · 2019-02-22T14:27:30.000-07:00
diff --git a/ebird/server/server.go b/ebird/server/server.go
@@ -38,12 +38,9 @@ func speciesHandler(w http.ResponseWriter, r *http.Request) {
 	var mbr [4]float64
 	for i, x := range []string{"minx", "maxx", "miny", "maxy"} {
 		v := r.FormValue(x)
-		if v == "" {
-			continue
-		}
 		mbr[i], err = strconv.ParseFloat(v, 64)
 		if err != nil {
-			http.Error(w, fmt.Sprintf("invalid coordinate for %s: %s", x, v), http.StatusBadRequest)
+			http.Error(w, fmt.Sprintf("invalid coordinate for %s: '%s'", x, v), http.StatusBadRequest)
 			return
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -38,12 +38,9 @@ func speciesHandler(w http.ResponseWriter, r *http.Request) {`
`38`	`38`	`var mbr [4]float64`
`39`	`39`	`for i, x := range []string{"minx", "maxx", "miny", "maxy"} {`
`40`	`40`	`v := r.FormValue(x)`
`41`		`- if v == "" {`
`42`		`- continue`
`43`		`- }`
`44`	`41`	`mbr[i], err = strconv.ParseFloat(v, 64)`
`45`	`42`	`if err != nil {`
`46`		`- http.Error(w, fmt.Sprintf("invalid coordinate for %s: %s", x, v), http.StatusBadRequest)`
	`43`	`+ http.Error(w, fmt.Sprintf("invalid coordinate for %s: '%s'", x, v), http.StatusBadRequest)`
`47`	`44`	`return`
`48`	`45`	`}`
`49`	`46`	`}`