Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date sorting doesn't work if one of the value is null #155

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

risalfajar
Copy link
Contributor

If one of the columns contain a null value (as in the test cases), the built-in date sorting won't work. I've fixed it.

@bryanmylee bryanmylee merged commit 5974598 into bryanmylee:main Oct 14, 2023
1 check passed
@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 6231219779

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 74.962%

Totals Coverage Status
Change from base Build 5824891354: 0.1%
Covered Lines: 810
Relevant Lines: 1031

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants