Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance: Mobile Compatibility for Timer Activation #142

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Enhance: Mobile Compatibility for Timer Activation #142

merged 3 commits into from
Oct 29, 2023

Conversation

bryanlundberg
Copy link
Owner

@bryanlundberg bryanlundberg commented Oct 29, 2023 •
edited
Loading

What does this PR do?
Introduce an additional feature enabling users to activate the timer by simply tapping the screen on their phones and tablets.

Related Issue(s)
#60

Changes

  • Implement eventListeners for the "touch" event.
  • Isolate the logic from the component.
  • Optimize the code for better maintainability.

By submitting this PR, I confirm that:

  • I have reviewed my code and believe it is ready for merging.
  • I understand that this PR may be subject to review and changes.
  • I agree to abide by the code of conduct and contributing guidelines of this project.

@bryanlundberg bryanlundberg changed the title Add compatibility for mobile version Enhance: Mobile Compatibility for Timer Activation Oct 29, 2023
@bryanlundberg bryanlundberg linked an issue Oct 29, 2023 that may be closed by this pull request
Add touch support for mobile devices #60
Closed
@bryanlundberg bryanlundberg merged commit dfc338c into main Oct 29, 2023
3 checks passed
@bryanlundberg bryanlundberg deleted the timer branch November 7, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add touch support for mobile devices
1 participant
@bryanlundberg