Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider rethrowing IndexOutOfRangeException from symbolic conversion as either ParseException or ConversionException. #46

Open
bryanedds opened this issue Oct 22, 2023 · 0 comments
Open

Consider rethrowing IndexOutOfRangeException from symbolic conversion as either ParseException or ConversionException. #46

bryanedds opened this issue Oct 22, 2023 · 0 comments
Assignees
@bryanedds
Labels
enhancement New feature or request

Comments

@bryanedds
Copy link
Owner

bryanedds commented Oct 22, 2023 •
edited
Loading

Alternatively, we could check for length wherever this could happen and throw parse or conversion exn directly.

Either way, I don't think we want IndexOutOfRangeException to escape from the conversion API.
@bryanedds bryanedds added the enhancement New feature or request label Oct 22, 2023
@bryanedds bryanedds added this to the ASAP milestone Oct 22, 2023
@bryanedds bryanedds self-assigned this Oct 22, 2023
@bryanedds bryanedds removed this from the ASAP milestone Dec 6, 2023
@bryanedds bryanedds changed the title Consider catching IndexOutOfRangeException from symbolic conversion and rethrowing as either parse or conversion exn. Consider rethrowing IndexOutOfRangeException from symbolic conversion as either ParseException or ConversionException. Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanedds bryanedds

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bryanedds