add missing SCNotification attributes (#254)

* add missing SCNotification attributes (and fix spelling error "SCINTILLANOTFICATION"), fix #253

* fix spelling error in documentation

* update default case to include *all* parameters (as the comment indicates)
simplify cases for DWELLSTART/END and MARGRIN(RIGHT)CLICK as they are the same returns

* add some missing parameters to docs [skip ci]

Co-authored-by: VinsWorldcom <vin@vinsworld.com>

Author: vinsworldcom

PythonScript/src/ScintillaWrapper.cpp

@@ -106,6 +106,7 @@ void ScintillaWrapper::notify(SCNotification *notifyCode)
 
 			case SCN_CHARADDED:
 				params["ch"] = notifyCode->ch;
+				params["characterSource"] = notifyCode->characterSource;
 				break;
 
 			case SCN_SAVEPOINTREACHED:
@@ -170,11 +171,6 @@ void ScintillaWrapper::notify(SCNotification *notifyCode)
 				break;
 
 			case SCN_MARGINCLICK:
-				params["margin"] = notifyCode->margin;
-                params["position"] = notifyCode->position;
-                params["modifiers"] = notifyCode->modifiers;
-   				break;
-
 			case SCN_MARGINRIGHTCLICK:
 				params["margin"] = notifyCode->margin;
                 params["position"] = notifyCode->position;
@@ -190,21 +186,18 @@ void ScintillaWrapper::notify(SCNotification *notifyCode)
 				break;
 
 			case SCN_USERLISTSELECTION:
+				params["position"] = notifyCode->position;
+				params["ch"] = notifyCode->ch;
 				params["text"] = notifyCode->text;
 				params["listType"] = notifyCode->listType;
-                params["position"] = notifyCode->position;
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
 				break;
 
 			case SCN_URIDROPPED:
                 params["text"] = notifyCode->text;
 				break;
 
 			case SCN_DWELLSTART:
-				params["position"] = notifyCode->position;
-				params["x"] = notifyCode->x;
-				params["y"] = notifyCode->y;
-				break;
-
 			case SCN_DWELLEND:
 				params["position"] = notifyCode->position;
 				params["x"] = notifyCode->x;
@@ -232,8 +225,10 @@ void ScintillaWrapper::notify(SCNotification *notifyCode)
 				break;
 
 			case SCN_AUTOCSELECTION:
+				params["position"] = notifyCode->position;
+				params["ch"] = notifyCode->ch;
 				params["text"] = notifyCode->text;
-                params["position"] = notifyCode->position;
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
 				break;
 
 			case SCN_AUTOCCANCELLED:
@@ -246,9 +241,20 @@ void ScintillaWrapper::notify(SCNotification *notifyCode)
 			case SCN_FOCUSOUT:
                 break;
 
+			case SCN_AUTOCCOMPLETED:
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
+				break;
+
+			case SCN_AUTOCSELECTIONCHANGE:
+				params["position"] = notifyCode->position;
+				params["text"] = notifyCode->text;
+				params["listType"] = notifyCode->listType;
+
 			default:
 				// Unknown notification, so just fill in all the parameters.
 				params["position"] = notifyCode->position;
+				params["ch"] = notifyCode->ch;
+				params["modifiers"] = notifyCode->modifiers;
 				params["modificationType"] = notifyCode->modificationType;
 				if (notifyCode->text) 
 				{
@@ -258,18 +264,21 @@ void ScintillaWrapper::notify(SCNotification *notifyCode)
 				}
 				params["length"] = notifyCode->length;
 				params["linesAdded"] = notifyCode->linesAdded;
+				params["message"] = notifyCode->message;
+				params["wParam"] = notifyCode->wParam;
+				params["lParam"] = notifyCode->lParam;
 				params["line"] = notifyCode->line;
 				params["foldLevelNow"] = notifyCode->foldLevelNow;
 				params["foldLevelPrev"] = notifyCode->foldLevelPrev;
-				params["annotationLinesAdded"] = notifyCode->annotationLinesAdded;
+				params["margin"] = notifyCode->margin;
 				params["listType"] = notifyCode->listType;
-				params["message"] = notifyCode->message;
-				params["wParam"] = notifyCode->wParam;
-				params["lParam"] = notifyCode->lParam;
-				params["modifiers"] = notifyCode->modifiers;
-				params["token"] = notifyCode->token;
 				params["x"] = notifyCode->x;
 				params["y"] = notifyCode->y;
+				params["token"] = notifyCode->token;
+				params["annotationLinesAdded"] = notifyCode->annotationLinesAdded;
+				params["updated"] = notifyCode->updated;
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
+				params["characterSource"] = notifyCode->characterSource;
 				break;
 			}
 

docs/source/enums.rst

@@ -59,15 +59,15 @@ STATUSBARSECTION
 
 SCINTILLANOTIFICATION
 ---------------------
-.. _SCINTILLANOTFICATION:
-.. class:: SCINTILLANOTFICATION
+.. _SCINTILLANOTIFICATION:
+.. class:: SCINTILLANOTIFICATION
 .. attribute:: SCINTILLANOTIFICATION.STYLENEEDED
 
    Arguments contains: ``position``
 
 .. attribute:: SCINTILLANOTIFICATION.CHARADDED
 
-   Arguments contains: ``ch`` - the character added (as an int)
+   Arguments contains: ``ch`` - the character added (as an int), ``characterSource``
 
 .. attribute:: SCINTILLANOTIFICATION.SAVEPOINTREACHED
 
@@ -85,6 +85,8 @@ SCINTILLANOTIFICATION
 
 .. attribute:: SCINTILLANOTIFICATION.UPDATEUI
 
+   Arguments contains: ``updated``
+
 .. attribute:: SCINTILLANOTIFICATION.MODIFIED
 
    Arguments contains: ``position``, ``modificationType`` (a set of flags from :class:`MODIFICATIONFLAGS`), ``text``, ``length``, ``linesAdded``, ``line``, ``foldLevelNow``, ``foldLevelPrev``,
@@ -104,17 +106,21 @@ SCINTILLANOTIFICATION
 
 .. attribute:: SCINTILLANOTIFICATION.NEEDSHOWN
 
+   Arguments contains: ``position``, ``length``
+
 .. attribute:: SCINTILLANOTIFICATION.PAINTED
 
    Note: Because Scintilla events are processed by Python asynchronously, care must be taken if handling a callback for this event
    - the window may have just been painted, or it may have been painted again since etc.
 
 .. attribute:: SCINTILLANOTIFICATION.USERLISTSELECTION
 
-   Arguments contains: ``text``, ``listType``, ``position``
+   Arguments contains: ``position``, ``ch``, ``text``, ``listType``, ``listCompletionMethod``
 
 .. attribute:: SCINTILLANOTIFICATION.URIDROPPED
 
+   Arguments contains: ``text``
+
 .. attribute:: SCINTILLANOTIFICATION.DWELLSTART
 
    Arguments contains: ``position``, ``x``, ``y``
@@ -139,12 +145,16 @@ SCINTILLANOTIFICATION
 
 .. attribute:: SCINTILLANOTIFICATION.AUTOCSELECTION
 
-   Arguments contains: ``text``, ``position``
+   Arguments contains: ``position``, ``ch``, ``text``, ``listCompletionMethod``
 
 .. attribute:: SCINTILLANOTIFICATION.INDICATORCLICK
 
+   Arguments contains: ``position``, ``modifiers``
+
 .. attribute:: SCINTILLANOTIFICATION.INDICATORRELEASE
 
+   Arguments contains: ``position``, ``modifiers``
+
 .. attribute:: SCINTILLANOTIFICATION.AUTOCCANCELLED
 
 .. attribute:: SCINTILLANOTIFICATION.AUTOCCHARDELETED
@@ -153,6 +163,13 @@ SCINTILLANOTIFICATION
 
 .. attribute:: SCINTILLANOTIFICATION.FOCUSOUT
 
+.. attribute:: SCINTILLANOTIFICATION.AUTOCOMPLETED
+
+   Arguments contains: ``listCompletionMethod``
+
+.. attribute:: SCINTILLANOTIFICATION.AUTOCSELECTIONCHANGE
+
+   Arguments contains: ``position``, ``text``, ``listType``
 
 SCINTILLAMESSAGE
 ----------------