move sinon to a devDependency#70
Merged
pulkitsharma07 merged 1 commit intobrowserstack:masterfrom Jul 23, 2019
Merged
Conversation
Contributor
Author
|
I just noticed that this is kind of a dupe with #54 - but that one is now bitrotted and has conflicts. |
Contributor
Author
|
ping @raghuhit - any chance we can get this merged in and a new release? |
Contributor
Author
|
@pulkitsharma07 can you take a look at this? |
Contributor
|
Thanks @alecf, sorry for the delay ! |
Contributor
|
@raghuhit can you publish this to npm ? |
Contributor
|
@alecf Sorry for delay. @pulkitsharma07 published to npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sinonused by this package is kind of ancient and it's relying on even more ancient packages (samsam) - by moving it todevDependencies, consumers won't have to install it or its old dependencies.