test fixes

Author: amaanbs

lib/LocalBinary.js

@@ -24,16 +24,16 @@ function LocalBinary(){
       return this.sourceURL;
     }
 
-    if (process.env.BINARY_DOWNLOAD_SOURCE_URL !== undefined && process.env.BINARY_DOWNLOAD_FALLBACK_ENABLED == "true" && this.parentRetries != 4) {
+    if (process.env.BINARY_DOWNLOAD_SOURCE_URL !== undefined && process.env.BINARY_DOWNLOAD_FALLBACK_ENABLED == 'true' && this.parentRetries != 4) {
       /* This is triggered from Local.js if there's an error executing the downloaded binary */
       return process.env.BINARY_DOWNLOAD_SOURCE_URL;
     }
-      
+
     let cmd, opts;
     cmd = 'node';
     opts = [path.join(__dirname, 'fetchDownloadSourceUrl.js'), this.key];
-    
-    if (retries == 4 || (process.env.BINARY_DOWNLOAD_FALLBACK_ENABLED == "true" && this.parentRetries == 4)) {
+
+    if (retries == 4 || (process.env.BINARY_DOWNLOAD_FALLBACK_ENABLED == 'true' && this.parentRetries == 4)) {
       opts.push(true, this.downloadErrorMessage || process.env.BINARY_DOWNLOAD_ERROR_MESSAGE);
     } else {
       opts.push(false, null);
@@ -47,7 +47,7 @@ function LocalBinary(){
     } else if (conf.useCaCertificate) {
       opts.push(undefined, undefined, conf.useCaCertificate);
     }
-    
+
     const userAgent = [packageName, version].join('/');
     const env = Object.assign({ 'USER_AGENT': userAgent }, process.env);
     const obj = childProcess.spawnSync(cmd, opts, { env: env });
@@ -59,7 +59,7 @@ function LocalBinary(){
       let output = Buffer.from(JSON.parse(JSON.stringify(obj.stderr)).data).toString();
       throw(output);
     }
-  }
+  };
 
   this.getDownloadPath = function (conf, retries) {
     let sourceURL = this.getSourceUrl(conf, retries) + '/';
@@ -91,8 +91,8 @@ function LocalBinary(){
 
   this.binaryDownloadError = function(errorMessagePrefix, errorMessage) {
     console.error(errorMessagePrefix, errorMessage);
-    this.downloadErrorMessage = errorMessagePrefix + " : " + errorMessage;
-  }
+    this.downloadErrorMessage = errorMessagePrefix + ' : ' + errorMessage;
+  };
 
   this.retryBinaryDownload = function(conf, destParentDir, callback, retries, binaryPath) {
     var that = this;
@@ -118,7 +118,7 @@ function LocalBinary(){
     } catch (e) {
       return console.error(`Unable to fetch the source url to download the binary with error: ${e}`);
     }
-    
+
     console.log('Downloading in sync');
     var that = this;
     if(!this.checkPath(destParentDir))
@@ -169,7 +169,7 @@ function LocalBinary(){
     } catch (e) {
       return console.error(`Unable to fetch the source url to download the binary with error: ${e}`);
     }
-    
+
     var that = this;
     if(!this.checkPath(destParentDir))
       fs.mkdirSync(destParentDir);

lib/fetchDownloadSourceUrl.js

@@ -4,9 +4,10 @@ const https = require('https'),
 
 const authToken = process.argv[2], proxyHost = process.argv[5], proxyPort = process.argv[6], useCaCertificate = process.argv[7], downloadFallback = process.argv[3], downloadErrorMessage = process.argv[4];
 
-let body = '', data = {"auth_token": authToken};
+let body = '', data = {'auth_token': authToken};
 const options = {
-  hostname: 'local.browserstack.com',
+  // hostname: 'local.browserstack.com',
+  hostname: 'k8s-devlocal.bsstag.com',
   port: 443,
   path: '/binary/api/v1/endpoint',
   method: 'POST',
@@ -15,9 +16,9 @@ const options = {
     'user-agent': process.env.USER_AGENT
   }
 };
-if (downloadFallback == "true") {
+if (downloadFallback == 'true') {
   options.headers['X-Local-Fallback-Cloudflare'] = true;
-  data["error_message"] = downloadErrorMessage;
+  data['error_message'] = downloadErrorMessage;
 }
 
 if(proxyHost && proxyPort) {
@@ -51,7 +52,7 @@ const req = https.request(options, res => {
   });
   res.on('error', (err) => {
     console.error(err);
-  })
+  });
 });
 req.on('error', e => {
   console.error(e);

test/local.js

@@ -280,7 +280,7 @@ describe('LocalBinary', function () {
       // ensure that we have a valid binary downloaded
 
       // removeIfInvalid();
-      (new LocalBinary()).binaryPath({}, 'abc', function(binaryPath) {
+      (new LocalBinary()).binaryPath({}, 'abc', 9, function(binaryPath) {
         defaultBinaryPath = binaryPath;
         tempfs.mkdir({
           recursive: true
@@ -313,7 +313,7 @@ describe('LocalBinary', function () {
         fs.writeFile(defaultBinaryPath, 'Random String', function() {
           fs.chmod(defaultBinaryPath, '0755', function() {
             localBinary.binaryPath({
-            }, 'abc', function(binaryPath) {
+            }, 'abc', 9, function(binaryPath) {
               expect(downloadStub.called).to.be.true;
               done();
             });
@@ -331,7 +331,7 @@ describe('LocalBinary', function () {
         });
 
         localBinary.binaryPath({
-        }, 'abc', function(binaryPath) {
+        }, 'abc', 9, function(binaryPath) {
           expect(downloadStub.called).to.be.true;
           done();
         });