Rename caCert to useCaCertificate.

Author: ryanreh99

README.md

@@ -78,10 +78,10 @@ To use a proxy for local testing -
 * proxyPort: Port for the proxy, defaults to 3128 when -proxyHost is used
 * proxyUser: Username for connecting to proxy (Basic Auth Only)
 * proxyPass: Password for USERNAME, will be ignored if USERNAME is empty or not specified
-* caCert: Path to ca cert file, if required
+* useCaCertificate: Path to ca cert file, if required
 
 ```js
-bs_local_args = { 'key': '<browserstack-accesskey>', 'proxyHost': '127.0.0.1', 'proxyPort': '8000', 'proxyUser': 'user', 'proxyPass': 'password', 'caCert': '/Users/test/cert.pem' }
+bs_local_args = { 'key': '<browserstack-accesskey>', 'proxyHost': '127.0.0.1', 'proxyPort': '8000', 'proxyUser': 'user', 'proxyPass': 'password', 'useCaCertificate': '/Users/test/cert.pem' }
 ```
 
 #### Local Proxy

lib/Local.js

@@ -183,9 +183,9 @@ function Local(){
         }
         break;
 
-      case 'caCert':
+      case 'useCaCertificate':
         if(value)
-          this.caCert = value;
+          this.useCaCertificate = value;
         break;
 
       case 'proxyHost':
@@ -250,8 +250,8 @@ function Local(){
         conf.proxyHost = this.proxyHost;
         conf.proxyPort = this.proxyPort;
       }
-      if (this.caCert) {
-        conf.caCert = this.caCert;
+      if (this.useCaCertificate) {
+        conf.useCaCertificate = this.useCaCertificate;
       }
       if(!callback) {
         return this.binary.binaryPath(conf);
@@ -292,9 +292,9 @@ function Local(){
     }
     if(this.onlyAutomateFlag)
       args.push(this.onlyAutomateFlag);
-    if (this.caCert) {
+    if (this.useCaCertificate) {
       args.push('--use-ca-certificate');
-      args.push(this.caCert);
+      args.push(this.useCaCertificate);
     }
     if(this.proxyHost){
       args.push('--proxy-host');

lib/LocalBinary.js

@@ -73,11 +73,11 @@ function LocalBinary(){
     opts = [path.join(__dirname, 'download.js'), binaryPath, this.httpPath];
     if(conf.proxyHost && conf.proxyPort) {
       opts.push(conf.proxyHost, conf.proxyPort);
-      if (conf.caCert) {
-        opts.push(conf.caCert);
+      if (conf.useCaCertificate) {
+        opts.push(conf.useCaCertificate);
       }
-    } else if (conf.caCert) {
-      opts.push(undefined, undefined, conf.caCert);
+    } else if (conf.useCaCertificate) {
+      opts.push(undefined, undefined, conf.useCaCertificate);
     }
 
     try{
@@ -118,9 +118,9 @@ function LocalBinary(){
         port: conf.proxyPort
       });
     }
-    if (conf.caCert) {
+    if (conf.useCaCertificate) {
       try {
-        options.ca = fs.readFileSync(conf.caCert);
+        options.ca = fs.readFileSync(conf.useCaCertificate);
       } catch(err) {
         console.log("failed to read cert file", err)
       }

lib/download.js

@@ -3,7 +3,7 @@ const https = require('https'),
   HttpsProxyAgent = require('https-proxy-agent'),
   url = require('url');
 
-const binaryPath = process.argv[2], httpPath = process.argv[3], proxyHost = process.argv[4], proxyPort = process.argv[5], caCert = process.argv[6];
+const binaryPath = process.argv[2], httpPath = process.argv[3], proxyHost = process.argv[4], proxyPort = process.argv[5], useCaCertificate = process.argv[6];
 
 var fileStream = fs.createWriteStream(binaryPath);
 
@@ -13,9 +13,9 @@ if(proxyHost && proxyPort) {
     host: proxyHost,
     port: proxyPort
   });
-  if (caCert) {
+  if (useCaCertificate) {
     try {
-      options.ca = fs.readFileSync(caCert);
+      options.ca = fs.readFileSync(useCaCertificate);
     } catch(err) {
       console.log("failed to read cert file", err)
     }