Also emit 'file' event for files with syntax errors #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `parseDeps` emitted an error event when there was a syntax error, and then returned undefined. Inside `persistentCacheFallback()`, then, the callback would not be called. This used to be OK but the persistent cache changes in v6 changed the callback, so now _it_ is responsible for 'file' and 'error' events. This patch changes `parseDeps` to throw instead of emit an error. This bubbles up to `persistentCacheFallback()` where it is caught and passed to the callback. Then that callback will first emit a 'file' event for the file and only then emit the 'error' event. This makes watchify aware of the file, so it will watch it and rebuild when it changes. Fixes #144 (really this time!)
|
📦 6.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
parseDepsemitted an error event when there was a syntaxerror, and then returned undefined. Inside
persistentCacheFallback(),then, the callback would not be called. This used to be OK but the
persistent cache changes in v6 changed the callback, so now it is
responsible for 'file' and 'error' events.
This patch changes
parseDepsto throw instead of emit an error. Thisbubbles up to
persistentCacheFallback()where it is caught and passedto the callback. Then that callback will first emit a 'file' event for
the file and only then emit the 'error' event.
This makes watchify aware of the file, so it will watch it and rebuild
when it changes. Fixes #144 (really this time!)