Screw MSIE 8/9 support. #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3229579. Conflicts: package.json
Member
|
hmm, events is pretty heavily depended upon as a browser version of node's |
Author
|
That's quite right... however, how many would be affected? all products i'm familiar with have dropped support for it years ago already. |
Member
|
IE9 supports most of ES5 so we can probably support that fairly easily. I'm OK with doing this otherwise. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to suggest to be pragmatic here and screw support for these rather obsolete browsers.
Mainly, to prevent the bloated code, and also i think it will make further maintainability with the Node.js events API easier in the long run.
Thanks for consideration.