Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify search path #90

Merged
merged 1 commit into from
May 11, 2018
Merged

Conversation

GuiltyDolphin
Copy link
Contributor

In readme.markdown, it states:

If you require('./foo.js') from /beep/boop/bar.js, node will
look for ./foo.js in /beep/boop/foo.js. Paths that start with a ./ or
../ are always local to the file that calls require().

But I don't think it makes sense to say it searches for
foo.js in foo.js here, so I've updated it to read:

If you require('./foo.js') from /beep/boop/bar.js, node will
look for foo.js in /beep/boop. Paths that start with a ./ or
../ are always local to the file that calls require().

Not sure if you want it to be /beep/boop/ rather than /beep/boop?

@goto-bus-stop goto-bus-stop merged commit e2fc3eb into browserify:master May 11, 2018
@goto-bus-stop
Copy link
Member

yeah this makes sense to me. thanks!

@GuiltyDolphin GuiltyDolphin deleted the gd/fix-path branch May 16, 2018 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants