Removed frame_id empty string passing

Author: monadoid

src/stagehand/session.py

@@ -2,7 +2,7 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING, Any, Union, Mapping, TypeVar, cast
+from typing import TYPE_CHECKING, Any, Union
 from datetime import datetime
 from typing_extensions import Unpack, Literal
 
@@ -24,15 +24,6 @@
 from .types.session_observe_response import SessionObserveResponse
 from .types.session_navigate_response import SessionNavigateResponse
 
-TSessionParams = TypeVar("TSessionParams", bound=Mapping[str, Any])
-
-
-def _with_default_frame_id(params: TSessionParams) -> TSessionParams:
-    prepared = dict(params)
-    if "frame_id" not in prepared:
-        prepared["frame_id"] = ""
-    return cast(TSessionParams, prepared)
-
 if TYPE_CHECKING:
     from ._client import Stagehand, AsyncStagehand
 
@@ -62,7 +53,7 @@ def navigate(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     def act(
@@ -80,7 +71,7 @@ def act(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     def observe(
@@ -98,7 +89,7 @@ def observe(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     def extract(
@@ -116,7 +107,7 @@ def extract(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     def execute(
@@ -134,7 +125,7 @@ def execute(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     def end(
@@ -182,7 +173,7 @@ async def navigate(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     async def act(
@@ -200,7 +191,7 @@ async def act(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     async def observe(
@@ -218,7 +209,7 @@ async def observe(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     async def extract(
@@ -236,7 +227,7 @@ async def extract(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     async def execute(
@@ -254,7 +245,7 @@ async def execute(
             extra_query=extra_query,
             extra_body=extra_body,
             timeout=timeout,
-            **_with_default_frame_id(params),
+            **params,
         )
 
     async def end(

test_local_mode.py

@@ -47,7 +47,6 @@
     client.sessions.navigate(
         id=session_id,
         url="https://example.com",
-        frame_id="",
     )
     print("✅ Navigation complete")  # noqa: T201
 

tests/test_sessions_create_helper.py

@@ -44,7 +44,7 @@ def test_sessions_create_returns_bound_session(respx_mock: MockRouter, client: S
     assert navigate_route.called is True
     first_call = cast(Call, navigate_route.calls[0])
     request_body = json.loads(first_call.request.content)
-    assert request_body["frameId"] == ""
+    assert "frameId" not in request_body
 
 
 @pytest.mark.respx(base_url=base_url)
@@ -77,4 +77,4 @@ async def test_async_sessions_create_returns_bound_session(
     assert navigate_route.called is True
     first_call = cast(Call, navigate_route.calls[0])
     request_body = json.loads(first_call.request.content)
-    assert request_body["frameId"] == ""
+    assert "frameId" not in request_body