reloading properties results in docker cloud locations being removed #314
Description
Looks like #290 or a variant of it.
Had a running successful docker cloud called my-docker-cloud-prod and a left-over from a failed deployment called my-docker-cloud-beta (this was as a result of accidentally unmanaging a running infrastructure, the location was left behind). Reloading properties resulted in all docker cloud and docker host locations being removed from the catalog.
2016-05-10 10:14:39,802 DEBUG c.d.location.DockerResolver [brooklyn-jetty-server-8443-qtp641517929-83235]: Resolving location 'docker:QzI5LaSC:(name="my-docker-cloud-prod")' with flags spec.named.name=my-docker-cloud-prod,spec.original=my-docker-cloud-prod
2016-05-10 10:14:39,802 DEBUG c.d.location.DockerResolver [brooklyn-jetty-server-8443-qtp641517929-83235]: Resolving location 'docker:QzI5LaSC:UTTDvQMy:(name="docker-hEkT0ZL9-Hl3DE7Ac")' with flags spec.named.name=docker-hEkT0ZL9-Hl3DE7Ac,spec.original=docker-hEkT0ZL9-Hl3DE7Ac
2016-05-10 10:14:39,803 DEBUG c.d.location.DockerResolver [brooklyn-jetty-server-8443-qtp641517929-83235]: Resolving location 'docker:CTDa5MRD:QU2dMv6U:(name="docker-U8GVB7lh-w76pX4B8")' with flags spec.named.name=docker-U8GVB7lh-w76pX4B8,spec.original=docker-U8GVB7lh-w76pX4B8
2016-05-10 10:14:39,803 DEBUG c.d.location.DockerResolver [brooklyn-jetty-server-8443-qtp641517929-83235]: Resolving location 'docker:GcysXXE1:(name="my-docker-cloud-beta")' with flags spec.named.name=my-docker-cloud-beta,spec.original=my-docker-cloud-beta
2016-05-10 10:14:39,803 DEBUG c.d.location.DockerResolver [brooklyn-jetty-server-8443-qtp641517929-83235]: Resolving location 'docker:GcysXXE1:YuoBgOOL:(name="docker-BPD9vrgI-fVMx6sVz")' with flags spec.named.name=docker-BPD9vrgI-fVMx6sVz,spec.original=docker-BPD9vrgI-fVMx6sVz
2016-05-10 10:14:41,594 DEBUG o.a.b.c.m.p.BrooklynMementoPersisterToObjectStore [brooklyn-execmanager-rTm3BHMx-15714]: Checkpointed delta of memento in 7ms: updated 2 entities, 2 locations, 2 policies, 11 enrichers, 0 catalog items; removed 0 entities, 0 locations, 0 policies, 0 enrichers, 0 catalog items
2016-05-10 10:14:41,853 DEBUG brooklyn.REST [brooklyn-jetty-server-8443-qtp641517929-86913]: Request IfV6cg starting: POST /v1/server/properties/reload from xx.xx.xx.xx
2016-05-10 10:14:41,854 INFO o.a.b.c.m.i.LocalManagementContext [brooklyn-jetty-server-8443-qtp641517929-86913]: Reloading brooklyn properties from Builder{defaultLocationMetadataUrl=classpath://brooklyn/location-metadata.properties, globalLocationMetadataUrl=/home/cloudsoft/.brooklyn/location-metadata.properties, globalPropertiesFile=/home/cloudsoft/.brooklyn/brooklyn.properties}
2016-05-10 10:14:41,854 WARN o.a.b.c.m.i.LocalManagementContext [brooklyn-jetty-server-8443-qtp641517929-86913]: When reloading, mgmt context LocalManagementContext[SuVnqpfr-rTm3BHMx] properties are fixed, so reload will be of limited utility
2016-05-10 10:14:41,857 INFO o.a.b.c.m.i.LocalManagementContext [brooklyn-jetty-server-8443-qtp641517929-86913]: Reloading additional brooklyn properties from {}
2016-05-10 10:14:41,857 DEBUG o.a.b.c.BrooklynFeatureEnablement [brooklyn-jetty-server-8443-qtp641517929-86913]: Init feature enablement did nothing, as no settings in brooklyn properties
2016-05-10 10:14:41,857 DEBUG o.a.b.r.s.p.DelegatingSecurityProvider [brooklyn-jetty-server-8443-qtp641517929-86913]: org.apache.brooklyn.rest.security.provider.DelegatingSecurityProvider@18dcdff9 reloading security provider
2016-05-10 10:14:41,858 INFO o.a.b.r.s.p.DelegatingSecurityProvider [brooklyn-jetty-server-8443-qtp641517929-86913]: REST using security provider org.apache.brooklyn.rest.security.provider.ExplicitUsersSecurityProvider
2016-05-10 10:14:41,858 INFO o.a.b.r.s.p.ExplicitUsersSecurityProvider [brooklyn-jetty-server-8443-qtp641517929-86913]: REST allowing users: [xxxxxx]
2016-05-10 10:14:41,859 DEBUG o.a.b.r.u.DefaultExceptionMapper [brooklyn-jetty-server-8443-qtp641517929-86913]: REST request running as WebEntitlementContext[xxxxxx@xx.xx.xx.xx:IfV6cg] threw: java.lang.NullPointerException: config locationName
2016-05-10 10:14:41,860 WARN o.a.b.r.u.DefaultExceptionMapper [brooklyn-jetty-server-8443-qtp641517929-86913]: REST call generated exception type class java.lang.NullPointerException unrecognized in class org.apache.brooklyn.rest.util.DefaultExceptionMapper (subsequent occurrences will be logged debug only): java.lang.NullPointerException: config locationName
java.lang.NullPointerException: config locationName
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:253) ~[guava-16.0.1.jar:na]
at clocker.docker.location.DockerLocation.register(DockerLocation.java:147) ~[brooklyn-clocker-docker-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at clocker.docker.location.DockerLocation$1.reloaded(DockerLocation.java:141) ~[brooklyn-clocker-docker-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at org.apache.brooklyn.core.mgmt.internal.LocalManagementContext.reloadBrooklynProperties(LocalManagementContext.java:410) ~[brooklyn-core-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at org.apache.brooklyn.rest.util.BrooklynRestResourceUtils.reloadBrooklynProperties(BrooklynRestResourceUtils.java:607) ~[brooklyn-rest-resources-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at org.apache.brooklyn.rest.resources.ServerResource.reloadBrooklynProperties(ServerResource.java:100) ~[brooklyn-rest-resources-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.7.0_99]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) ~[na:1.7.0_99]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.7.0_99]
at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_99]
at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180) ~[cxf-core-3.1.4.jar:3.1.4]
at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96) ~[cxf-core-3.1.4.jar:3.1.4]
at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:200) [cxf-rt-frontend-jaxrs-3.1.4.jar:3.1.4]
at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:99) [cxf-rt-frontend-jaxrs-3.1.4.jar:3.1.4]
at org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:59) [cxf-core-3.1.4.jar:3.1.4]
at org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:96) [cxf-core-3.1.4.jar:3.1.4]
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308) [cxf-core-3.1.4.jar:3.1.4]
at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121) [cxf-core-3.1.4.jar:3.1.4]
at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:251) [cxf-rt-transports-http-3.1.4.jar:3.1.4]
at org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:234) [cxf-rt-transports-http-3.1.4.jar:3.1.4]
at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:208) [cxf-rt-transports-http-3.1.4.jar:3.1.4]
at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:160) [cxf-rt-transports-http-3.1.4.jar:3.1.4]
at org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:180) [cxf-rt-transports-http-3.1.4.jar:3.1.4]
at org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:293) [cxf-rt-transports-http-3.1.4.jar:3.1.4]
at org.apache.cxf.transport.servlet.AbstractHTTPServlet.doPost(AbstractHTTPServlet.java:212) [cxf-rt-transports-http-3.1.4.jar:3.1.4]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) [javax.servlet-api-3.1.0.jar:3.1.0]
at org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:268) [cxf-rt-transports-http-3.1.4.jar:3.1.4]
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:808) [jetty-servlet-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669) [jetty-servlet-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.apache.brooklyn.rest.filter.LoggingFilter.doFilter(LoggingFilter.java:91) [brooklyn-rest-server-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) [jetty-servlet-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.apache.brooklyn.rest.filter.RequestTaggingFilter.doFilter(RequestTaggingFilter.java:51) [brooklyn-rest-server-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) [jetty-servlet-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585) [jetty-servlet-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:542) [jetty-security-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515) [jetty-servlet-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.Server.handle(Server.java:499) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257) [jetty-server-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540) [jetty-io-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635) [jetty-util-9.2.13.v20150730.jar:9.2.13.v20150730]
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555) [jetty-util-9.2.13.v20150730.jar:9.2.13.v20150730]
at java.lang.Thread.run(Thread.java:745) [na:1.7.0_99]
2016-05-10 10:14:41,861 DEBUG brooklyn.REST [brooklyn-jetty-server-8443-qtp641517929-86913]: Request IfV6cg completed in 7ms: response 500 for POST /v1/server/properties/reload from xx.xx.xx.xx, headers: Cookie: JSESSIONID_BROOKLYNNdHgm3=36wxflz354n1hg2g7vh4qxtm; JSESSIONID_BROOKLYNmel4Sq=tnz28eq5xagi125q390u9wzdp, Host: xx.xx.xx.xx:8443, X-Requested-With: XMLHttpRequest, Content-Length: 0, User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36, Origin: https://xx.xx.xx.xx:8443, Connection: keep-alive, Accept-Language: en-US,en;q=0.8, Authorization: ******, Referer: https://xx.xx.xx.xx:8443/, Accept-Encoding: gzip, deflate, Accept: */*, Content-Type: application/json