Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1633] Remove WFL_SLACK_ENABLED feature switch #587

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

okotsopoulos
Copy link
Contributor

@okotsopoulos okotsopoulos commented Mar 4, 2022

Purpose

Feature switch originally added here: #571

Slack notifications have been verified to work in WFL prod.

I've also removed WFL_SLACK_ENABLED environment variable assignments in gotc-deploy repo: https://github.com/broadinstitute/gotc-deploy/pull/331

System Tests

Off of a local WFL without WFL_SLACK_ENABLED environment set, ran system tests and observed that the expected Slack message was emitted.

wm111-e35:wfl okotsopo$ cd api; WFL_WFL_URL=http://localhost:3000 clojure -M:test --focus wfl.system.v1-endpoint-test/test-workload-sink-outputs-to-tdr
--- system (clojure.test) ---------------------------
wfl.system.v1-endpoint-test
  test-workload-sink-outputs-to-tdr

1 tests, 7 assertions, 0 failures.

Top 1 slowest kaocha.type/clojure.test (769.46063 seconds, 100.0% of total time)
  system
    769.46063 seconds average (769.46063 seconds / 1 tests)

Top 1 slowest kaocha.type/ns (769.45496 seconds, 100.0% of total time)
  wfl.system.v1-endpoint-test
    769.45496 seconds average (769.45496 seconds / 1 tests)

Top 1 slowest kaocha.type/var (769.45032 seconds, 100.0% of total time)
  wfl.system.v1-endpoint-test/test-workload-sink-outputs-to-tdr
    769.45032 seconds wfl/system/v1_endpoint_test.clj:412

Full suite passes:

wm111-e35:wfl okotsopo$ make TARGET=system
export CPCACHE=/Users/okotsopo/wfl/api/.cpcache;            \
	export WFL_WFL_URL=http://localhost:3000; \
	clojure  -M:parallel-test wfl.system.v1-endpoint-test | \
	tee /Users/okotsopo/wfl/derived/api/system.log
WARNING: Specified path is external to project: ../derived/api/src
WARNING: Specified path is external to project: ../derived/api/resources

Ran 33 tests containing 374 assertions.
0 failures, 0 errors.
api system finished on Fri Mar 4 15:36:41 EST 2022
docs system finished on Fri Mar 4 15:36:41 EST 2022
functions/aou system finished on Fri Mar 4 15:36:41 EST 2022
functions/sg system finished on Fri Mar 4 15:36:41 EST 2022
helm system finished on Fri Mar 4 15:36:41 EST 2022
ui system finished on Fri Mar 4 15:36:41 EST 2022

Now Slack notifications are always enabled.
@okotsopoulos okotsopoulos requested a review from tbl3rd March 4, 2022 20:26
@okotsopoulos okotsopoulos merged commit 08edeee into develop Mar 8, 2022
@okotsopoulos okotsopoulos deleted the okotsopo/GH-1633-remove-slack-feature-switch branch March 8, 2022 20:17
okotsopoulos added a commit that referenced this pull request Mar 21, 2022
GH-1592 GH-1635 Notify Slack watchers on Terra submission creation (#591)
GH-1593 Notify Slack watchers on failed TDR snapshot jobs (#590)
GH-1618 Add workload info to executor logs (#589)
GH-1633 Remove WFL_SLACK_ENABLED feature switch (#587)
okotsopoulos added a commit that referenced this pull request Mar 22, 2022
GH-1592 GH-1635 Notify Slack watchers on Terra submission creation (#591)
GH-1593 Notify Slack watchers on failed TDR snapshot jobs (#590)
GH-1618 Add workload info to executor logs (#589)
GH-1633 Remove WFL_SLACK_ENABLED feature switch (#587)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants