Add service account credentialing #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpblanken
commented
Dec 10, 2024
| 'REFERENCE_GENOME': reference_genome.value, | ||
| 'PIPELINE_RUNNER_APP_VERSION': Env.PIPELINE_RUNNER_APP_VERSION, | ||
| }, | ||
| 'service_account': service_account_credentials.service_account_email, |
Collaborator
Author
There was a problem hiding this comment.
Note we will also call get_service_account_credentials() downstream when we actually make the API request. This ensures we properly scope and credential the cluster at spinup time.
jklugherz
reviewed
Dec 12, 2024
|
|
||
|
|
||
| def get_service_account_credentials() -> google.oauth2.credentials.Credentials: | ||
| global SERVICE_ACCOUNT_CREDENTIALS |
Contributor
There was a problem hiding this comment.
Why are you using the global keyword here?
Contributor
There was a problem hiding this comment.
I think I figured it out. Is it because we don't want to reset SERVICE_ACCOUNT_CREDENTIALS every time get_service_account_credentials() is called?
Collaborator
Author
There was a problem hiding this comment.
I'm changing a variable with global scope. More info: https://stackoverflow.com/questions/4693120/why-isnt-the-global-keyword-needed-to-access-a-global-variable
Collaborator
Author
There was a problem hiding this comment.
yeah, we just refresh the token.
jklugherz
approved these changes
Dec 12, 2024
bpblanken
added a commit
that referenced
this pull request
Dec 13, 2024
* Add service account credentialing (#997) * Add service account credentialing * ruff * feat: Handle parsing empty predicted sex into Unknown (#1000) * Add helper functions for querying `Terra Data Repository` (#998) * Add service account credentialing * ruff * First pass * tests passing * add coverage of bigquery test * change function names * use generators everywhere * bq requirement * resolver * Update sample id name * Build Sex Check Table from TDR Metrics (#999)
bpblanken
added a commit
that referenced
this pull request
Jan 7, 2025
* Add service account credentialing (#997) * Add service account credentialing * ruff * feat: Handle parsing empty predicted sex into Unknown (#1000) * Add helper functions for querying `Terra Data Repository` (#998) * Add service account credentialing * ruff * First pass * tests passing * add coverage of bigquery test * change function names * use generators everywhere * bq requirement * resolver * Update sample id name * Build Sex Check Table from TDR Metrics (#999) * refactor: Move feature flags to FeatureFlag enum. (#1002) * refactor: Move feature flags out of environment to their own dataclass * lint: ruff * ruff * bugfix: exclude samples from relationship checking that are not present in the expected loadable samples (#1003) * bugfix: exclude samples from relationship checking that are not present in the expected loadable samples * cleanup * feat: add remap and family loading failures as validation exceptions … (#1005) * feat: add remap and family loading failures as validation exceptions rather than runtime errors * move on * Update write_remapped_and_subsetted_callset_test.py * ruff * feat: Add ability to run tasks dataproc. (#948) * Support gcs dirs in rsync * ws * Add create dataproc cluster task * add dataproc * ruff * requirements * still struggling * Gencode refactor to remove gcs * bump reqs * Run dataproc job * lib * running * merge requirements * Flip'em * Better exception handling * Cleaner approach if less generalizable * write a test * Fix tests * lint * Add test for success * refactor to use a base class... better for adding support for multiple jobs * cleanup * ruff * Fix missing mock * Fix flapping test * pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service account token-ing is required for terra api requests...this gets us credentialed both locally and in dataproc.