This repository was archived by the owner on Mar 21, 2025. It is now read-only.
DDO-3517: cutover Data Repo to ESO #261
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 5th of 5 PRs to migrate data repo to ESO from Vault. This PR and DDO-3517 in terra-helmfile will cutover data repo to use ESO rather than Vault.
This PR removes the functionality of parsing and creating secrets from Vault from the data repo chart. At this point (due to the terra-helmfile PR), there will already be no Vault secrets in datarepo and it will be using ESO.
This repo (datarepo-helm) will hold the create-secret-manager-secret chart while terra-helmfile will hold the values.
This PR was tested by using the datarepo-helm-definitions repo. Using Olivia's setup, I pointed the chart to my local updated version of the create-secret-manager-secrets chart, after updating the values file in the definitions repos. I also pointed the values to my local versions of the terra-helmfile values files for dev, staging, prod, and BEEs.
helmfile.yaml:
After running
helmfile apply, for each iteration of my local chart and values files, I confirmed the output matches what I expect.