Improved dev workflow #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauanmayemir
force-pushed
the
feature/workflow
branch
2 times, most recently
from
ffd53ea to
40fbc4f
Compare
wokalski
reviewed
May 22, 2018
README.md
Outdated
|
|
||
| ## Acknowledgements | ||
|
|
||
| This project is directly based on the work of [@cristianoc](https://github.com/cristianoc) (`React Mini`) and [@whitequark](https://github.com/whitequark) (`opam-cross-*`). |
There was a problem hiding this comment.
whitequark's work is a bit unrelated now. I think he'd better be credited somewhere where the cross compilation tooling belongs.
rauanmayemir
force-pushed
the
feature/workflow
branch
2 times, most recently
from
e63185e to
2591e8b
Compare
|
@rauanmayemir |
|
But where are we going to put tests? |
wokalski
reviewed
May 22, 2018
.circleci/config.yml
Outdated
| paths: | ||
| - ~/.esy | ||
| - run: esy build | ||
| - run: yarn test |
There was a problem hiding this comment.
let's not make this detour through yarn. We should just run esy jbuilder runtest --no-buffer or have a ./test script that does just that.
|
how about |
rauanmayemir
force-pushed
the
feature/workflow
branch
2 times, most recently
from
080c76c to
65f3f45
Compare
rauanmayemir
force-pushed
the
feature/workflow
branch
from
65f3f45 to
74aa275
Compare
|
@wokalski Ready for review. 😎 |
wokalski
approved these changes
May 23, 2018
|
Yeah, we can add it when we start working on it. The important part was finding the best dir structure, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third time's a charm. 😆
esy.ocamlto4.06.