Implement getEnabledTraits for SourceControlPackageContainer

* added support for source control package container to fetch enabled traits
* cleanup of comments

Author: bripeticca

Sources/PackageGraph/ModulesGraph+Loading.swift

@@ -260,8 +260,6 @@ extension ModulesGraph {
             traitConfiguration: traitConfiguration
         )
 
-//        throw PackageGraphError.duplicateProduct(product: "asdf", packages: [])
-
         let rootPackages = resolvedPackages.filter { root.manifests.values.contains($0.manifest) }
         checkAllDependenciesAreUsed(packages: resolvedPackages, rootPackages, observabilityScope: observabilityScope)
 
@@ -438,15 +436,9 @@ private func createResolvedPackages(
         var dependenciesByNameForModuleDependencyResolution = [String: ResolvedPackageBuilder]()
         var dependencyNamesForModuleDependencyResolutionOnly = [PackageIdentity: String]()
 
-//        let isRoot = package.manifest.packageKind.isRoot
-//        let enableAllTraits = isRoot ? traitConfiguration?.enableAllTraits ?? false : false
-//        let enabledTraits = isRoot ? traitConfiguration?.enabledTraits : nil
-
         try package.manifest.dependenciesRequired(
             for: packageBuilder.productFilter,
-            nil
-//            enabledTraits
-//            enableAllTraits: enableAllTraits
+            nil // traits unneeded at this stage
         ).forEach { dependency in
             let dependencyPackageRef = dependency.packageRef
 

Sources/PackageGraph/PackageContainer.swift

@@ -102,7 +102,7 @@ public protocol PackageContainer {
     /// Fetch the enabled traits of a package container.
     ///
     /// NOTE: This method should only be called on root packages.
-    func getEnabledTraits(traitConfiguration: TraitConfiguration?, at version: Version?) async throws -> Set<String>
+    func getEnabledTraits(traitConfiguration: TraitConfiguration?, version: Version?) async throws -> Set<String>
 }
 
 extension PackageContainer {
@@ -118,7 +118,7 @@ extension PackageContainer {
         return true
     }
 
-    public func getEnabledTraits(traitConfiguration: TraitConfiguration?, at version: Version? = nil) async throws -> Set<String> {
+    public func getEnabledTraits(traitConfiguration: TraitConfiguration?, version: Version? = nil) async throws -> Set<String> {
         return []
     }
 }

Sources/PackageGraph/Resolution/PubGrub/PubGrubDependencyResolver.swift

@@ -501,7 +501,7 @@ public struct PubGrubDependencyResolver {
     /// decisions if nothing else is left to be done.
     /// After this method returns `solution` is either populated with a list of
     /// final version assignments or an error is thrown.
-    private func run(state: State/*, traitConfiguration: TraitConfiguration?*/) async throws {
+    private func run(state: State) async throws {
         var next: DependencyResolutionNode? = state.root
 
         while let nxt = next {
@@ -512,7 +512,7 @@ public struct PubGrubDependencyResolver {
 
             // If decision making determines that no more decisions are to be
             // made, it returns nil to signal that version solving is done.
-            next = try await self.makeDecision(state: state/*, traitConfiguration: traitConfiguration*/)
+            next = try await self.makeDecision(state: state)
         }
     }
 

Sources/Workspace/PackageContainer/SourceControlPackageContainer.swift

@@ -419,9 +419,12 @@ internal final class SourceControlPackageContainer: PackageContainer, CustomStri
         }
     }
 
-    public func getEnabledTraits(traitConfiguration: TraitConfiguration?, at version: Version?) async throws -> Set<String> {
-        // TODO: bp complete
-        return []
+    public func getEnabledTraits(traitConfiguration: TraitConfiguration?, at revision: String?, version: Version?) async throws -> Set<String> {
+        guard let version, let tag = getTag(for: version) else {
+            return []
+        }
+        let manifest = try await self.loadManifest(tag: tag, version: version)
+        return try manifest.enabledTraits(using: traitConfiguration?.enabledTraits, enableAllTraits: traitConfiguration?.enableAllTraits ?? false) ?? []
     }
 
     public var isRemoteContainer: Bool? {