Merge pull request #13 from brigun/bogus-counting

brigun · web-flow · commit 4944f5b46581 · 2017-03-15T14:29:33.000-05:00
Fixes #10, bogus counting issue.
diff --git a/src/main/java/com/teamtreehouse/flashy/services/FlashCardServiceImpl.java b/src/main/java/com/teamtreehouse/flashy/services/FlashCardServiceImpl.java
@@ -62,10 +62,9 @@ public FlashCard getNextFlashCardBasedOnViews(Map<Long, Long> idToViewCounts) {
         continue;
       }
       Long lowestScore = idToViewCounts.get(leastViewedId);
-      if (entry.getValue() >= lowestScore) {
-        break;
+      if (entry.getValue() < lowestScore) {
+        leastViewedId = entry.getKey();
       }
-      leastViewedId = entry.getKey();
     }
     return flashCardRepository.findOne(leastViewedId);
   }

Original file line number	Diff line number	Diff line change
`@@ -62,10 +62,9 @@ public FlashCard getNextFlashCardBasedOnViews(Map<Long, Long> idToViewCounts) {`
`62`	`62`	`continue;`
`63`	`63`	`}`
`64`	`64`	`Long lowestScore = idToViewCounts.get(leastViewedId);`
`65`		`- if (entry.getValue() >= lowestScore) {`
`66`		`- break;`
	`65`	`+ if (entry.getValue() < lowestScore) {`
	`66`	`+ leastViewedId = entry.getKey();`
`67`	`67`	`}`
`68`		`- leastViewedId = entry.getKey();`
`69`	`68`	`}`
`70`	`69`	`return flashCardRepository.findOne(leastViewedId);`
`71`	`70`	`}`