-
Notifications
You must be signed in to change notification settings - Fork 0
Fix librknnrt #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dcc1429
docs: Update gap analysis with fresh package comparison
scottrfrancis 10dfd32
feat: Update Claude settings for git operations
scottrfrancis 903d188
feat: Add librknnrt.so automatic download using reference project app…
scottrfrancis 58e8841
chore: Update Claude settings for SSH authentication
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
bsoe-recipes/meta-bs/recipes-open/librknnrt/librknnrt_2.3.2.bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -229,6 +229,28 @@ if [ $? -eq 0 ]; then | |||||
| echo "✅ SDK extracted to ${SCRIPT_DIR}/${SDK_BASENAME}" | ||||||
| # Clean up the copy in srv | ||||||
| rm -f "$SDK_FILE" | ||||||
|
|
||||||
| # Also install and patch SDK if requested | ||||||
| echo "Installing SDK to ./sdk directory..." | ||||||
| if "${SCRIPT_DIR}/${SDK_BASENAME}" -d "${SCRIPT_DIR}/sdk" -y; then | ||||||
| echo "✅ SDK installed to ./sdk" | ||||||
|
|
||||||
| # Patch SDK with Rockchip libraries (same as reference project) | ||||||
| echo "Adding librknnrt.so to SDK..." | ||||||
| cd "${SCRIPT_DIR}/sdk/sysroots/aarch64-oe-linux/usr/lib" | ||||||
| if [ ! -f "librknnrt.so" ]; then | ||||||
| if wget -q https://github.com/airockchip/rknn-toolkit2/raw/v2.3.2/rknpu2/runtime/Linux/librknn_api/aarch64/librknnrt.so; then | ||||||
| echo "✅ librknnrt.so downloaded to SDK" | ||||||
| else | ||||||
| echo "⚠️ Failed to download librknnrt.so - continuing anyway" | ||||||
| fi | ||||||
| else | ||||||
| echo "✅ librknnrt.so already present in SDK" | ||||||
| fi | ||||||
| cd "${SCRIPT_DIR}" | ||||||
|
||||||
| cd "${SCRIPT_DIR}" | |
| cd "$ORIG_PWD" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same security concern as in the package file - downloading executable library files without integrity verification poses a security risk. Consider adding checksum validation or using HTTPS with certificate verification.