Skip to content

fix(wayland_window): Call SetWindowGeometry for position updates OS-20350 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 28-x-y-bs
Choose a base branch
from
Open

fix(wayland_window): Call SetWindowGeometry for position updates OS-20350 #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/chromium/.patches
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,3 +195,4 @@ add_switch_to_disable_font_matching_cache_os-14352.patch
fix_overlay_strategy_for_html_pages_with_transparency_os-19250.patch
feat_nexus-window_implement_setopacity_support_for_nexus_platform.patch
ozone_nexus_implement_setfullscreen_for_nexuswindow_os-19899.patch
fix_wayland_window_call_setwindowgeometry_for_position_updates.patch
24 changes: 24 additions & 0 deletions patches/chromium/fix_wayland_window_call_setwindowgeometry_for_position_updates.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Caner Altinbasak <cal@brightsign.biz>
Date: Thu, 27 Nov 2025 15:21:12 +0000
Subject: fix(wayland_window): Call SetWindowGeometry for position updates
OS-20350

Our wayland compositor is modified to accept position updates. Chromium
ignores position updates, and only calls xdg_surface_set_window_geometry
when size changes. Modified the code to call Wayland for both
position and size changes.

diff --git a/ui/ozone/platform/wayland/host/wayland_window.cc b/ui/ozone/platform/wayland/host/wayland_window.cc
index 826f51c06d2c4b8e27dc994be15a35ad56147e1c..a33b888a35070cc25f9dd325e8373c99c3681bb5 100644
--- a/ui/ozone/platform/wayland/host/wayland_window.cc
+++ b/ui/ozone/platform/wayland/host/wayland_window.cc
@@ -1332,7 +1332,7 @@ void WaylandWindow::LatchStateRequest(const StateRequest& req) {
auto old_state = latched_state_;
latched_state_ = req.state;

- if (req.state.bounds_dip.size() != old_state.bounds_dip.size()) {
+ if (req.state.bounds_dip != old_state.bounds_dip) {
SetWindowGeometry(req.state.bounds_dip.size());
}
UpdateWindowMask();