Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The partial method doesn't support kwarg-only syntax #575

Closed
jaredcwhite opened this issue Jun 10, 2022 · 0 comments · Fixed by #582
Closed

The partial method doesn't support kwarg-only syntax #575

jaredcwhite opened this issue Jun 10, 2022 · 0 comments · Fixed by #582
Labels
bug Something isn't working
Milestone

Comments

@jaredcwhite
Copy link
Member

jaredcwhite commented Jun 10, 2022

While working on the roda-turbo plugin, it dawned on me that the partial method doesn't support a keyword arguments-only signature. You can do this:

partial "path/to/template", locals: { abc: 123 }

But not this:

partial template: "path/to/template", locals: { abc: 123 }

Which makes it hard to pass rendering options for the turbo_stream tag builder directly to partial. We should support both signatures.

@jaredcwhite jaredcwhite added the bug Something isn't working label Jun 10, 2022
@jaredcwhite jaredcwhite added this to the 1.1 milestone Jun 10, 2022
@jaredcwhite jaredcwhite changed the title The partial method doesn't support Hash-only syntax The partial method doesn't support kwarg-only syntax Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant