Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fable Compatiblity #1

Open
OnurGumus opened this issue Jun 20, 2024 · 4 comments
Open

Fable Compatiblity #1

OnurGumus opened this issue Jun 20, 2024 · 4 comments

Comments

@OnurGumus
Copy link

Thanks for the great library. I believe a good portion of this library could made Fable Compatible. So it would be nice to have it :)

@brianrourkeboll
Copy link
Owner

Thanks! I don't really have any experience with making Fable-compatible libraries yet. I've glanced at the authoring and compatibility guides, but I'm not 100% sure what needs to be changed.

Would it be enough to include the source files in a fable/ folder? Or is there something about the resumable-code-style computation expressions that would also need to be changed?

@OnurGumus
Copy link
Author

Sorry for my late reply. Yes these guides are good. You can try to write a mocha based unit test as well. Here's a sample library I fablized (with manual nuget push)

https://github.com/OnurGumus/ScanRat2

@brianrourkeboll
Copy link
Owner

brianrourkeboll commented Jul 22, 2024

@OnurGumus

Do you have a sense of what the most useful CEs would be for Fable? It seems unlikely that you'd want the ones for System.Collections.Immutable, for example.

Probably mostly the System.Collections.Generic ones: resizeArrayArray, hashSetSet, and dictionaryMap, right?

@OnurGumus
Copy link
Author

I personally don't use the immutable ones with Fable.
resizeArray is System.Collections.Generic.List which becomes array after transpiled to JS.

I think your list is pretty good. So you can skip the immutables and stick to the standard ones :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants