docs: add missing parameters on pg.Client Config #3422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- client_encoding - fallback_application_name - options
hjr3
changed the title
Deploying node-postgres with
|
| Latest commit: |
cd0c5f9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://527c09d9.node-postgres.pages.dev |
| Branch Preview URL: | https://push-rzmuwzznutyv.node-postgres.pages.dev |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==========
While working on pg-connection-string, I noticed that
client_encodingdid not exist onClientConfigin @types/pg. This led to me to discover that it was not a documented parameter as well.Reference: https://www.postgresql.org/docs/current/libpq-connect.html
Use in code:
client_encodingnode-postgres/packages/pg/lib/connection-parameters.js
Line 98 in d8fb2f9
fallback_application_namenode-postgres/packages/pg/lib/connection-parameters.js
Line 104 in d8fb2f9
optionsnode-postgres/packages/pg/lib/connection-parameters.js
Line 79 in d8fb2f9