Skip to content

Commit ca7bb68

Browse files
committed
always run docker
1 parent f592a04 commit ca7bb68

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

internal/validation/suite.go

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,6 @@ func RunNetworkValidation(t *testing.T, config ProviderConfig, opts NetworkValid
248248
type FirewallValidationOpts struct {
249249
// TestPort is the port to test firewall blocking on (should NOT be in allowed ingress)
250250
TestPort int
251-
// TestDockerFirewall enables docker firewall validation (requires Docker on instance)
252-
TestDockerFirewall bool
253251
}
254252

255253
func RunFirewallValidation(t *testing.T, config ProviderConfig, opts FirewallValidationOpts) {
@@ -319,13 +317,10 @@ func RunFirewallValidation(t *testing.T, config ProviderConfig, opts FirewallVal
319317
require.NoError(t, err, "ValidateFirewallBlocksPort should pass - port should be blocked")
320318
})
321319

322-
// Test that Docker container on 0.0.0.0 is blocked (if enabled)
323-
if opts.TestDockerFirewall {
324-
t.Run("ValidateDockerFirewallBlocksPort", func(t *testing.T) {
325-
err := v1.ValidateDockerFirewallBlocksPort(ctx, client, instance, ssh.GetTestPrivateKey(), testPort)
326-
require.NoError(t, err, "ValidateDockerFirewallBlocksPort should pass - docker port should be blocked")
327-
})
328-
}
320+
t.Run("ValidateDockerFirewallBlocksPort", func(t *testing.T) {
321+
err := v1.ValidateDockerFirewallBlocksPort(ctx, client, instance, ssh.GetTestPrivateKey(), testPort)
322+
require.NoError(t, err, "ValidateDockerFirewallBlocksPort should pass - docker port should be blocked")
323+
})
329324

330325
// Test that SSH port is accessible (sanity check)
331326
t.Run("ValidateSSHPortAccessible", func(t *testing.T) {

0 commit comments

Comments
 (0)