-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piracy! #10
Comments
This one too TimeseriesTools.jl/src/Utils.jl Line 23 in d64a95b
Whats the use-case here? |
Hey, sorry for the wait; busy week! I've been learning more about DimensionalData.jl as I go, so much of this code is sub-optimal. There are definitely some cases of lazy piracy here 😅; would be good to get them expunged. Extending Base.stack is probably better handled like this: rafaqz/DimensionalData.jl#645
Often I'd have two DimArrays with a common dimension, say A and B. I'd one dimension of A through some pipeline, then later want to match the dimensions of B with the reduced A: e.g. |
Closed by adding custom DimArray and Dimension subtypes in #14 |
Hi! was just looking through your code for our integration section of the DImensionalData.jl docs, and I just noticed some friendly piracy going on here 🏴☠️ !!
TimeseriesTools.jl/src/Utils.jl
Line 58 in d64a95b
Maybe this should go in DimensionalData.jl proper so we are all above board? Currently this will mean
stack
will only work when TimeseriesTools.jl is loaded, which might confuse some users....Its also kind of confusing that we already have something called a
DimStack
that is totally different toBase.stack
, but it would be useful to havestack
working all the same.The text was updated successfully, but these errors were encountered: