Correctly detect java in -tid, don't double annotate. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stackcollapse was detecting java programs correctly when profiling the process, but failing when --tid was used. Switched to matching start of string. Also, auto annotation caused double annotation (discovered when implementing perf-map-agent native annotation).
|
The tests fail on the differing output, please let me know that you are happy with the change and I will fix the tests ASAP |
|
ping? |
|
ok, thanks! |
|
ah wait, it broke the tests... |
|
We'll just fix the tests afterwards. Thanks. |
|
We watched jon pull his hair our for 20 mins thanks to this haha |
jonhoo
added a commit
to jonhoo/FlameGraph
that referenced
this pull request
Jul 14, 2024
This was planned[1] but never happened. May be worthwhile to make CI run `test.sh` -- I'll submit a separate PR that does so. [1]: brendangregg#147 (comment)
jonhoo
added a commit
to Orca-bit/inferno
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stackcollapse was detecting java programs correctly when profiling
the process, but failing when --tid was used. Switched to matching
start of string.
Also, auto annotation caused double annotation (discovered when
implementing perf-map-agent native annotation).