Skip to content

Conversation

@1ed
Copy link
Contributor

@1ed 1ed commented Jan 5, 2024

No description provided.

@1ed
Copy link
Contributor Author

1ed commented Jan 10, 2024

@mnapoli could you please merge this and the other PHP 8.3 PRs? Thanks!

@ddeboer
Copy link
Contributor

ddeboer commented Jan 18, 2024

Yes, would be nice to have all the PHP 8.3 PRs merged to allow devs to upgrade their projects to 8.3.

@mnapoli @Nyholm Please let us know how we can help getting these PRs merged. Perhaps an extra maintainer with merge rights? Or automatically merging and tagging small PRs such as this?

@mnapoli
Copy link
Member

mnapoli commented Jan 18, 2024

I'm torn, I'm not sure we actually want more things maintained here.

This repo is a collection of partially broken things, the promise for users is fairly low unfortunately. (because it's impossible to maintain all these extensions)

I'm wondering if we should just encourage people to have repos for the extensions they are actually maintaining instead of giving a false promise to users.

Anyway, that's a sidebar…

I cannot merge this today, the release process takes too much manual time and I won't have time to complete it today. I'll try tomorrow 👍

@ddeboer
Copy link
Contributor

ddeboer commented Jan 18, 2024

I'm wondering if we should just encourage people to have repos for the extensions they are actually maintaining instead of giving a false promise to users.

Makes sense. Should the Bref docs then be updated to describe how to build your own extension layer?

@Nyholm
Copy link
Collaborator

Nyholm commented Jan 18, 2024

I would be happy to continue the discussion, Maybe start an issue.

I'll merge this and prepare a release.

@Nyholm Nyholm merged commit 20aaa69 into brefphp:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants