Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Autoplay is not always blocked on steam games store. #9384

Open
ShockRocky opened this issue Apr 22, 2020 · 4 comments
Open

[Desktop] Autoplay is not always blocked on steam games store. #9384

ShockRocky opened this issue Apr 22, 2020 · 4 comments
Labels
feature/autoplay OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@ShockRocky
Copy link

Description

Brave is inconsistent with blocking autoplay on the steam page.

Steps to Reproduce

  1. Go to any steam game webpage, for eg -https://store.steampowered.com/app/1076600/Red_Gate/

  2. Even when the autoplay block message is being shown on the address bar, the video continues to play without any user interaction.

  3. Delete the webpages cookies, should have the same result, or sometimes it is blocked, which is why, as stated in the title, the behavior seems to be inconsistent.

Actual result:

Autoplay is inconsistently blocked.

Expected result:

Autoplay should always be blocked.

Reproduces how often:

Inconsistently.

Brave version (brave://version info)

Brave :- 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)

Revision :- e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}

OS:- Windows 10 OS Version 1909 (Build 18363.778)

Version/Channel Information:

  • Can you reproduce this issue with the current release?Yes.
  • Can you reproduce this issue with the beta channel?Haven't tried.
  • Can you reproduce this issue with the dev channel?Haven't tried.
  • Can you reproduce this issue with the nightly channel?Haven't tried.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?No.
  • Does the issue resolve itself when disabling Brave Rewards?No.
  • Is the issue reproducible on the latest version of Chrome? Haven't tried.
@rebron
Copy link
Collaborator

rebron commented Jun 5, 2020

possibly fixed with #9597

@rebron
Copy link
Collaborator

rebron commented Jun 5, 2020

cc: @kjozwiak to check on Steam

@rebron rebron added feature/autoplay OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 5, 2020
@srirambv srirambv changed the title Autoplay is not always blocked on steam games store. [Desktop] Autoplay is not always blocked on steam games store. Sep 9, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 14, 2020

@ShockRocky Is this still an issue for you? We had a fix that may have addressed this same issue in #9597 quite some time ago. Our latest is 1.15.72. If you can give that a try, let us know.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2021

@ShockRocky are you still experiencing the above? With the latest version of Brave, we leave autoplay enabled by default. However, you can disable it via brave://settings/content/autoplay.

Verified that it's working on Win 10 x64 using the following builds:

Brave | 1.18.77 Chromium: 87.0.4280.101 (Official Build) (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2009 (Build 19042.685)
Brave | 1.19.72 Chromium: 87.0.4280.101 (Official Build) beta (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2009 (Build 19042.685)
Brave | 1.20.58 Chromium: 88.0.4315.7 (Official Build) nightly (64-bit)
-- | --
Revision | 9b020863b2987261f6dcd018c6b388041c035f98-refs/branch-heads/4315@{#15}
OS | Windows 10 OS Version 2009 (Build 19042.685)

Went through the following STR/Cases

  • ensured that autoplay is enabled by default via brave://settings/content/autoplay and videos were automatically played
  • disable autoplay via brave://settings/content/autoplay and ensured that videos weren't being automatically played
  • ensured that allowing https://store.steampowered.com:443 correctly added an entry within brave://settings/content/autoplay and played videos without issues even though autoplay has is disabled
  • ensured that removing https://store.steampowered.com:443 from the Allow list under brave://settings/content/autoplay stopped automatically playing videos.

Links used for the above cases:

Example Example
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/autoplay OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Status: P3 Backlog
Development

No branches or pull requests

3 participants