Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix colors on various modals provided by Chromium #40535

Open
1 of 6 tasks
LaurenWags opened this issue Aug 19, 2024 · 1 comment
Open
1 of 6 tasks

fix colors on various modals provided by Chromium #40535

LaurenWags opened this issue Aug 19, 2024 · 1 comment
Labels
OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

The colors on the "Make Brave Faster" modal look more "Chrome blue" than "Brave blurple". They should be updated to match our coloring.

Steps to reproduce

Not sure how to reproduce, just stumbled across the modal/notification

Actual result

This is on dark theme, not sure if the same colors apply to light theme

Screenshot 2024-08-19 at 12 10 45 PM

Expected result

Colors should be more "Brave" less "Chrome"

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.69.147 Chromium: 128.0.6613.40 (Official Build) (x86_64)
Revision d29b1747d0f906239936b0d94c40889920ebf2c0
OS macOS Version 13.6.9 (Build 22G830)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @mkarolin

@LaurenWags LaurenWags added polish Nice to have — usually related to front-end/visual tasks release-notes/exclude OS/Desktop labels Aug 19, 2024
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 19, 2024
@LaurenWags LaurenWags changed the title fix colors on "Make Brave Faster" modal fix colors on various modals provided by Chromium Sep 18, 2024
@LaurenWags
Copy link
Member Author

Saw on another modal with 1.72.6 Chromium: 129.0.6668.42, no idea how this modal was triggered though. It doesn't look Chrome blue but it does look odd.

Screenshot 2024-09-18 at 7 16 35 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude
Projects
Status: On Deck
Development

No branches or pull requests

2 participants