Skip to content

fix bottom padding for Top Sites #30674

Closed
brave/brave-core
#18708

Description

Description

We'll need to fix/improve the padding on Top Sites, specifically at the bottom padding. You'll notice that the padding at the top looks good but there's not enough padding at the bottom. See example below.

Steps to reproduce

  1. install brave and open a new tab (Top Tiles don't load on the first initial NTP)
  2. once you've opened a NTP, you'll notice that there isn't enough bottom padding for Top Sites

Actual result

Screenshot_20230529-154644

Expected result

We should add more padding at the bottom of the Top Sites so it looks the same as the top padding. Right now, it doesn't look symmetrical.

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: Android 14 (also reproducible with Android 13)

Brave version

Brave | 1.54.18 Chromium: 114.0.5735.53 (Official Build) canary (32-bit)
--- | ---
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Android 13; Build/UPB2.230407.014; 33; UpsideDownCake

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions