Skip to content

Crash on Glide image download #29473

Closed
brave/brave-core
#17891

Description

I found that crash on beta 1.51.x in backtrace. It could happen when we start download of an image in crypto wallet when Activity is dying or dead. Not sure we can verify it properly, I just put a try catch.

java.lang.IllegalArgumentException: You cannot start a load for a destroyed activity
        at com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed(RequestManagerRetriever.java:348)
        at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:148)
        at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:128)
        at com.bumptech.glide.Glide.with(Glide.java:801)
        at org.chromium.chrome.browser.app.helpers.ImageLoader.loadImage(ImageLoader.java:276)
        at org.chromium.chrome.browser.app.helpers.ImageLoader.lambda$downloadImage$2(ImageLoader.java:157)
        at org.chromium.components.image_fetcher.NetworkImageFetcher.lambda$fetchImage$0(NetworkImageFetcher.java:40)
        at org.chromium.components.image_fetcher.ImageFetcherBridge.lambda$fetchImage$1(ImageFetcherBridge.java:99)
        at org.chromium.base.Callback$Helper.onObjectResultFromNative(Callback.java:41)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:340)
        at android.os.Looper.loopOnce(Looper.java:169)
        at android.os.Looper.loop(Looper.java:300)
        at android.app.ActivityThread.main(ActivityThread.java:8282)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:576)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions