Skip to content

Wallet on ramp providers for native assets #29248

Closed
brave/brave-core
#17713

Description

Description

We currently allow to buy native network assets even though on ramp provider doesn't support it.

Steps to reproduce

  1. Set a locale to US so Sardine provider could be seen.
  2. Create a wallet and go to a Buy flow.
  3. Pick a Binance Smart Chain Mainnet and BNB as an asset to buy.
  4. Press Buy button.

Actual result

Observe Ramp.Network, Sardine and Transak there.
Screenshot_20230321_144408

Expected result

Only Ramp.Network and Transak should be there as you can't buy BNB via Sardine.

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.51.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Type

No type

Projects

  • Status

    Done

Relationships

None yet

Development

No branches or pull requests

Issue actions