Skip to content

retire Binance widget rather than completely removing #19888

Closed
brave/brave-core
#11485

Description

Description

As per discussions, we'll be reverting brave/brave-core#11148 from 1.35.x & 1.34.x and will implement the following which aligns closer to what desktop did via brave/brave-core#11266.

As per @bbondy, we'll do the following:

* Retire it to the Edit stack screen (i.e. equivalent to gallery on Desktop) for new users or if a user hasn't used it.
* Keep it there for users that have connected to it

Steps to reproduce

Test Case #1

  1. install 1.34.34 Chromium: 96.0.4664.45 which has Binance as a widget
  2. upgrade to 1.35.4 Chromium: 96.0.4664.55 and it will be completely removed (even if you're authenticated)

Actual result

Binance is being completely removed even if users are authenticated when upgrading to a version with brave/brave-core#11148.

Expected result

* Retire it to the Edit stack screen (i.e. equivalent to gallery on Desktop) for new users or if a user hasn't used it.
* Keep it there for users that have connected to it

Issue reproduces how often

100% reproducible using the STR/Cases mentioned above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: Android 12

Brave version

1.35.4 Chromium: 96.0.4664.55

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @bsclifton @rebron @srirambv @bbondy @deeppandya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions