Skip to content

Support procedural cosmetic filtering #16935

Closed
brave/brave-core
#24688
@antonok-edm

Description

Procedural cosmetic filtering is useful for the most evasive kinds of in-content sponsored/promoted material. It'd be great to implement this and tie it to aggressive shields settings, to handle the last few examples of cosmetic items slipping through on Reddit, YouTube, Facebook, etc.

See also:

Activity

self-assigned this
on Jul 13, 2021
antonok-edm

antonok-edm commented on Apr 12, 2022

@antonok-edm
CollaboratorAuthor

Another use/test case: sponsored posts on stuff.co.nz

image

Should be handled by stuff.co.nz##[itemprop]:has(.sponsored-flag)

intrnl

intrnl commented on Apr 12, 2022

@intrnl

How many filters makes use of other procedural selector? (e.g. :has-text)
I'd imagine Chrome's upcoming support for :has is going to make this slightly less necessary.

antonok-edm

antonok-edm commented on Apr 12, 2022

@antonok-edm
CollaboratorAuthor

How many filters makes use of other procedural selector? (e.g. :has-text)

I did a survey of procedural filter operator counts in Brave's default lists a few days ago:

:has
    164
:has-text
    336
:matches-css
    15
:matches-css-before
    19
:matches-css-after
    2
:matches-path
    12
:not
    165
:upward
    239
:xpath
    49

It's not an exact metric since some filters can contain multiple chained operators, and :not is a special case since it's also a valid CSS pseudo-class, but this list still gives a good idea of how important each is. has-text in particular would be great to support.

I'd imagine Chrome's upcoming support for :has is going to make this slightly less necessary.

The recent efforts on :has are commendable, but it actually has a really long history and who knows what else may delay the implementation. Plus, support procedural cosmetic filters in general should make :has fairly simple anyways.

edit: 172 occurrences of has-text, or roughly half, are actually from HTML filters (with a ##^ separator in the rule). That uses a totally separate system from procedural filtering, even though the rules look similar. I haven't seen any other procedural filters used for HTML filtering.

edit again: :has is actually implemented now! So just the other procedural filters are left now.

dharnil

dharnil commented on Mar 6, 2024

@dharnil

Hi Braver, Is there any update on this open ticket. I happy to contribute.

36 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Support procedural cosmetic filtering · Issue #16935 · brave/brave-browser